fix: create custom logs cleanup function #3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Apollon77
reviewed
Feb 19, 2024
Apollon77
approved these changes
Feb 19, 2024
api/lib/logger.ts
Outdated
| // clean up old log files based on maxFiles and maxSize | ||
|
|
||
| const filePathRegExp = new RegExp( | ||
| path.basename(settings.filename).replace(/%DATE%/g, '([^.]+)'), |
There was a problem hiding this comment.
settings.filename contains ".log", right? So the "." should be escaped?
There was a problem hiding this comment.
@Apollon77 in that case [^.]+ means: take everything that is not a dot. So it will stop just before the .log. This of course could be broken in case %DATE% contains a dot but 🤷🏼♂️
Example here: https://regex101.com/r/kKW5ox/1
There was a problem hiding this comment.
I created a new version of the regex to make it stronger, it will work for every date format, it just takes everything between the %DATE% prefix/suffix:
Pull Request Test Coverage Report for Build 8007979295Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #3609